The FreeiPodGuide Forums

Admin · Posted: Fri Apr 29, 2005 4:31 pm Post subject: TRADING MODULE!

I just spent the last 6 hours of this day off coding a trading module.

Here's the deal: You can initiate a trade with anyone on the board, using a link in their posts or in their profile.

Once initiated, this trade will appear in both of your "trades" areas. At this time, if the person you traded with wants to trade, he or she will "confirm" the trade. After that, the only way it will be deleted is if both of you set your 'status' to "requesting deletion".

If the person you asked to trade with does NOT wish to trade with you, he or she simply has to 'request deletion' without confirming it and it will be removed.

There are 11 different status settings for the various places each person in a trade can be. These are easy to add to if necessary.

Once both parties request TR for the trade, it will appear in a special admin-only panel where we can review the trade and credit + delete it as we see appropriate. Remember, trades among new users will still not be credited, and all the old rules apply. If you are requesting TR, make sure to indicate what was traded for in one or both of the 'notes' field.

If you have any questions, feel free to post here or PM me. Same goes for bug reports.

drummer_kew_03 · Posted: Fri Apr 29, 2005 4:43 pm Post subject:

Sounds like a great addition!

dudeextrem2000 · Posted: Fri Apr 29, 2005 5:57 pm Post subject:

awesome job admin

redskunk · Posted: Fri Apr 29, 2005 6:54 pm Post subject:

Sounds like a GREAT addition! Kudos!

Blink182=Gone · Posted: Fri Apr 29, 2005 7:02 pm Post subject:

sounds good...btw, do we have to use this in order to get +1's now?

Admin · Posted: Fri Apr 29, 2005 7:09 pm Post subject:

No, old method is still fine. Just prefer it if you use the new, as it makes it easier for us on the admin side.

thehunter1320 · Posted: Fri Apr 29, 2005 7:58 pm Post subject:

found a bug

when you're trying to change your own status, you can only see the otions for putting in -1

Admin · Posted: Sat Apr 30, 2005 10:49 am Post subject:

thehunter1320: Browser, version, OS, version?

Retro · Posted: Sun May 01, 2005 10:07 am Post subject:

hey, can there be something that notifies us of a new trade initiation? or do we have to just keep checking back in the trades section?

pSeuDo · Posted: Sun May 01, 2005 2:24 pm Post subject:

pSeuDo · Posted: Sun May 01, 2005 3:13 pm Post subject:

thats awesome for "new trades"

Phbs83 · Posted: Sun May 01, 2005 3:16 pm Post subject:

It's nice to have a list of all the statuses - 1 to 7 and what they mean:) Couldn't find that, and had to try everything in order to find what I need

Admin · Posted: Sun May 01, 2005 4:44 pm Post subject:

The status list was included in the javascript popup prompt, but IE doesn't allow more than a couple lines in that, so it was just getting eaten. I've moved that prompt to a more friendly location so it works on both IE and firefox.

I will add a 'new trade' alert later tonight, as well as cancel on status returning you to 'negotiation'.

Phbs83 · Posted: Sun May 01, 2005 4:49 pm Post subject:

Admin · Posted: Sun May 01, 2005 5:04 pm Post subject:

That was briefly put up just to make sure the javascript would work properly. In fact, you can see the javascript code if you view-> source any normal page on the forums.

As of now, though, it will never be triggered (not coded yet.)

Phbs83 · Posted: Sun May 01, 2005 5:07 pm Post subject:

It showed up, but even after I saw the trade, it remained "You have new trades". You should double-check the code before you start it. Just a suggestion, thanks for your hard work:)

Admin · Posted: Sun May 01, 2005 6:12 pm Post subject:

I just said it was only a test of the javascript used to display the alert. I just said the backend wasn't yet coded. I just said it wont be triggered again until I code it.

Is this difficult to understand?

pSeuDo · Posted: Sun May 01, 2005 6:32 pm Post subject:

Phbs83 · Posted: Sun May 01, 2005 6:53 pm Post subject:

Admin · Posted: Sun May 01, 2005 7:41 pm Post subject:

All done. Feel free to try it.

For simplicity/ease's sake the flag indicating that you have a new trade is only cleared after TWO page loads OR if you visit the trade page.

Basically, the PM one only shows up once, no matter what, and this one will only show up twice, no matter what, unless the first page you visit (since the trade was initiated) is the trading page.

Make sense?

Also, I believe I squised the 'cancel = negotiation' bug. Let me know if there are any others...

pSeuDo · Posted: Mon May 02, 2005 12:47 pm Post subject:

is there a way to make it so that if it is requesting deletion, and the other party doesn't reply in a week it gets deleted?

Admin · Posted: Mon May 02, 2005 2:55 pm Post subject:

No. The idea is that once the trade is confirmed, it will only be deleted if both parties agree. This is to prevent someone from attempting a trade, scamming, and deleting to cover it up.

If you have an old trade that neither of you have any intention of finishing, go ahead and PM me after a week or so if the other guy wont request deletion and I'll remove it manually.

pSeuDo · Posted: Mon May 02, 2005 2:58 pm Post subject:

okay, thanks =D

Admin · Posted: Wed May 04, 2005 6:52 pm Post subject:

Added a new status level, settable only by mods, called "TR Credited". So after both posts are "Requesting TR" and a mod approves them and credits the TR, he/she can mark as credited and then the parties concerned can either leave the record there or both request deletion.

Admin · Posted: Wed May 04, 2005 10:27 pm Post subject:

Added a facility to automatically convert urls in the 'comments' field to clickable hyperlinks. This was difficult to code but I think I have accounted for all possible situations (except where you put more than one link in there, but why in god's name would you do that?).

Let me know if you see any weird behavoir.

theysayjump · Posted: Wed May 04, 2005 10:33 pm Post subject:

sweet, sounds good!

Admin · Posted: Sat May 07, 2005 5:13 pm Post subject:

Updated: Now uses a simpler drop-down box for status display and update.

pSeuDo · Posted: Sat May 07, 2005 8:53 pm Post subject:

steve30000 · Posted: Sun May 08, 2005 1:24 pm Post subject:

Maybe I'm not understanding this module completely but shouldn't there be a "Waiting for partner completion" (or something like that) in Status section? So if someone initiates a trade and has a lower trade record and goes yellow, I think I would want to change my status that I'm waiting for them to go green before completing the offer for them. There doesn't seem to be an option that satisfies that option.

Admin · Posted: Sun May 08, 2005 1:57 pm Post subject:

Makes sense.

I just changed "Negotiation" to "Negotiation or Waiting" since they're pretty much equivalent as far as a person's status goes. Sound good?

steve30000 · Posted: Sun May 08, 2005 2:02 pm Post subject:

Yeah, that looks good to me. Thanks.

Cinnabar · Posted: Tue May 24, 2005 8:24 am Post subject:

Admin, can we have something to where we can delete the trades that have already been credited by ourselves? I have requested deletion on several but since the other person hasn't, nothing happens.

Our lists get too cluttered. Sad

Admin · Posted: Sun May 29, 2005 8:44 am Post subject:

Okay, now a trade will be deleted if the status is "TR Credited" and one of the two users requests deletion.